Skip to content

Parcoords to also render last block increment #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2017
Merged

Parcoords to also render last block increment #1447

merged 2 commits into from
Mar 6, 2017

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Mar 6, 2017 •
edited
Loading

Incremental rendering didn't render the last block due to an off-by-one error.

@monfera monfera self-assigned this Mar 6, 2017
@monfera monfera added status: in progress bug something broken labels Mar 6, 2017
@monfera monfera requested a review from etpinard March 6, 2017 21:59
@monfera monfera changed the title Parcoords incremental rendering off by one error fix Parcoords to also render last block increment Mar 6, 2017
etpinard
etpinard approved these changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@etpinard etpinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done 💃

@monfera monfera merged commit 05c576c into master Mar 6, 2017
@monfera monfera deleted the parcoords-incremental-rendering-fix branch March 6, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@etpinard etpinard etpinard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@monfera monfera

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monfera @etpinard